Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8584#discussion_r38670214
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
    @@ -36,9 +36,7 @@ trait SharedSQLContext extends SQLTestUtils {
       /**
        * The [[TestSQLContext]] to use for all tests in this suite.
        */
    -  protected def ctx: TestSQLContext = _ctx
    --- End diff --
    
    +1.  Since we often deal with both spark and sql contexts, I'd like to 
uniformly use `sqlContext` throughout the codebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to