Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8496#issuecomment-137532016
@cloud-fan This change can only remove one copy for ArrayType and MapType,
we still have one additional copy for each level of Array or Struct. Can we
copy the elements into target UnsafeRow in one pass? (it will be harder, I
think it worth the effort since the changes in this PR is also not trivial).
BTW, it's better to separate real change and refactors to reduce the burden
of review, especially when the PR is large, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
