Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8217#discussion_r38702574
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1052,39 +1041,22 @@ class DAGScheduler(
                   //       we registered these map outputs.
                   mapOutputTracker.registerMapOutputs(
                     shuffleStage.shuffleDep.shuffleId,
    -                shuffleStage.outputLocs.map(list => if (list.isEmpty) null 
else list.head),
    +                shuffleStage.outputLocs.map(_.headOption.orNull),
                     changeEpoch = true)
     
                   clearCacheLocs()
    +
    +              // Some tasks had failed; let's resubmit this shuffleStage
    --- End diff --
    
    Why move this outside the if-statement? It looks like it only holds when 
the if-statement is true, so less confusing I think to have it inside.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to