Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8584#discussion_r38710809
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
 ---
    @@ -18,38 +18,20 @@
     package org.apache.spark.sql.hive
     
     import java.sql.Timestamp
    -import java.util.{Locale, TimeZone}
     
     import org.apache.hadoop.hive.conf.HiveConf
    -import org.scalatest.BeforeAndAfterAll
     
     import 
org.apache.spark.sql.execution.datasources.parquet.ParquetCompatibilityTest
    -import org.apache.spark.sql.hive.test.TestHive
    -import org.apache.spark.sql.{Row, SQLConf, SQLContext}
    -
    -class ParquetHiveCompatibilitySuite extends ParquetCompatibilityTest with 
BeforeAndAfterAll {
    -  override def _sqlContext: SQLContext = TestHive
    -  private val sqlContext = _sqlContext
    +import org.apache.spark.sql.{Row, SQLConf}
    +import org.apache.spark.sql.hive.test.TestHiveSingleton
     
    +class ParquetHiveCompatibilitySuite extends ParquetCompatibilityTest with 
TestHiveSingleton {
       /**
        * Set the staging directory (and hence path to ignore Parquet files 
under)
        * to that set by [[HiveConf.ConfVars.STAGINGDIR]].
        */
       private val stagingDir = new 
HiveConf().getVar(HiveConf.ConfVars.STAGINGDIR)
     
    -  private val originalTimeZone = TimeZone.getDefault
    -  private val originalLocale = Locale.getDefault
    -
    -  protected override def beforeAll(): Unit = {
    -    TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))
    -    Locale.setDefault(Locale.US)
    -  }
    -
    -  override protected def afterAll(): Unit = {
    -    TimeZone.setDefault(originalTimeZone)
    -    Locale.setDefault(originalLocale)
    -  }
    --- End diff --
    
    We have already done this in `QueryTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to