GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/8596
[SPARK-10443] Refactor SortMergeOuterJoin to reduce duplication
`LeftOutputIterator` and `RightOutputIterator` are symmetrically identical
and can share a lot of code. If someone makes a change in one but forgets to do
the same thing in the other we'll end up with inconsistent behavior. This patch
also adds inline comments to clarify the intention of the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark smoj-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8596
----
commit cc4b553e145a5c3e1a18e1c1c1318092225a6e00
Author: Andrew Or <[email protected]>
Date: 2015-09-04T02:32:13Z
Refactor Left/RightOutputIterator + add comments
This commit merges the two existing output iterator classes in
an effort to reduce the symmetrically duplicate code. It also
adds comments to make it more readable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
