Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8180#issuecomment-137745960
Sorry Andrew, I certainly didn't mean to imply that I knew your opinion on
this particular patch -- as Sean said, I was just trying to point out the
general situation. My point is just that new features add complexity, and make
it harder to fix bugs; and we have plenty of complexity and bugs now. I don't
mean to block the patch, its a cool feature. I'm just nervous about any change
to the dag scheduler (eg., even my own proposal in
https://github.com/apache/spark/pull/8427, which is 30 lines + 100 lines of
tests, and most likely needs more testing still). Perhaps I err too much on
the side of caution, I'm just providing a counterpoint.
Thanks for adding the the additional tests, Matei. Btw, there is an
example test for skipped stages you should be able to copy more or less here:
https://github.com/apache/spark/pull/8402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
