Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8509#discussion_r38773863
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -229,4 +229,81 @@ class ParquetQuerySuite extends QueryTest with
ParquetTest with SharedSQLContext
}
}
}
+
+ test("SPARK-10301 Clipping nested structs in requested schema") {
--- End diff --
Can we list all cases that are tested at here? Cases that should be here
will be
* two struct types have the same fields
* two struct types have totally two different set of fields
* one struct type is a super set of another one
* there are some common fields. But, there are also fields that only exist
in one file. I believe that the ordering of fields is also matter at here. For
example, for a struct in the global schema, if its fields are `a, b, c, d`, `a,
d` in local struct and `a, b` in struct filed are two different cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
