Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8602#discussion_r38782875
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -991,21 +991,30 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
val nonexistentKey = "nonexistent"
// "set" itself returns all config variables currently specified in
SQLConf.
- assert(sql("SET").collect().size == 0)
+ assert(sql("SET").collect().size == TestSQLContext.overrideConfs.size)
+ sql("SET").collect().foreach { row =>
+ val key = row.getString(0)
+ val value = row.getString(1)
+ assert(
+ TestSQLContext.overrideConfs.contains(key),
+ s"$key should not exist in SQLConf.")
--- End diff --
this should be `key should exist` right? or `key does not exist in SQLConf`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
