Github user GraceH commented on the pull request:
https://github.com/apache/spark/pull/7888#issuecomment-138161276
@andrewor14 Thanks for the comments.
Regarding #1, very good point. That's why I try to return back false if
force-killing failed. This is the simplest way. That `executorID` won't be
added to `executorsPendingToRemove.add(executorId)`. See
https://github.com/GraceH/spark/blob/forcekill/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala#L410.
The only concern here is that it somehow changes the semantics for that return
value.
Regarding #2, Nice suggestion. That's also my thoughts too. The end user
can force kill any executor by setting force=true. I will make private function
for `ExecutorAllocationManager`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
