Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/964#issuecomment-46398707
@vrilleup Thanks for updating the PR! I made a comment on the explicit type
checks. I'm a little confused about the new API. If `isDenseSVD` is true, `tol`
doesn't mean anything. In MATLAB and SciPy, `svds` and `svd` are separate
functions. We should either do the same or hide the parameters from users.
Having `computeSVD(k, computeU)` should be sufficient for most users. What do
you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
