Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8635#discussion_r39002021
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/UnsafeRowSerializer.scala
---
@@ -143,7 +143,7 @@ private class UnsafeRowSerializerInstance(numFields:
Int) extends SerializerInst
override def readKey[T: ClassTag](): T = {
// We skipped serialization of the key in writeKey(), so just
return a dummy value since
// this is going to be discarded anyways.
- null.asInstanceOf[T]
+ (-1).asInstanceOf[T]
--- End diff --
then of course we need to relax the assertion in `writeKey` and add a
comment that explains why we need to accept `key == null` there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
