Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8663#discussion_r39004973
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -169,6 +169,41 @@ private[spark] object BLAS extends Serializable with
Logging {
}
/**
+ * Adds alpha * x * x.t to a matrix in-place. This is the same as BLAS's
DSPR.
+ *
+ * @param U the upper triangular part of the matrix packed in an array
(column major)
+ */
+ def dspr(alpha: Double, v: Vector, U: Array[Double]): Unit = {
--- End diff --
* Should be `spr` instead of `dspr`. We only use double precision.
* It might be useful to make `U` a `DenseVector` (or add a convenient
method) for API consistency.
* Do you mind adding tests for both dense and sparse input?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
