Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/8635#issuecomment-138883641
  
    @andrewor14 seems very difficult to have a very simple unit test, as 
`ExternalSorter` have to work with lots of other components, hence I added some 
mock stuff.
    
    Those mock stuff should be helpful, as I found some other interesting bug, 
and I can continue to fix it once this merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to