Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8664#discussion_r39088739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -132,13 +132,12 @@ case class GetJsonObject(json: Expression, path:
Expression)
}
if (parsed.isDefined) {
+ val parser = jsonFactory.createParser(jsonStr.getBytes)
+ val output = new ByteArrayOutputStream()
+ val generator = jsonFactory.createGenerator(output,
JsonEncoding.UTF8)
--- End diff --
what if these things threw exceptions? Can you make them `var`s instead and
do a null check in finally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
