Github user massie commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7403#discussion_r39095321
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -70,12 +71,13 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
        * In addition, users can control the partitioning of the output RDD, 
and whether to perform
        * map-side aggregation (if a mapper can produce multiple items with the 
same key).
        */
    -  def combineByKey[C](createCombiner: V => C,
    +  def combineByKeyWithClassTag[C](
    --- End diff --
    
    Because `PairRDDFunctions` is a stable API, we can't change the method 
signature of `combineByKey`. Adding the `ClassTag`, would add an implicit 
argument. If we leave the old `combineByKey` methods and add new `combineByKey` 
methods with `ClassTag`s, then we get compiler errors being unable to resolve 
the `combineByKey` symbol.
    
    If you know as way of doing this more cleanly, I would be happy to make 
that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to