Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8674#discussion_r39107728
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -192,11 +193,10 @@ object DateTimeUtils {
* Returns Julian day and nanoseconds in a day from the number of
microseconds
*/
def toJulianDay(us: SQLTimestamp): (Int, Long) = {
- val seconds = us / MICROS_PER_SECOND
- val day = seconds / SECONDS_PER_DAY + JULIAN_DAY_OF_EPOCH
- val secondsInDay = seconds % SECONDS_PER_DAY
- val nanos = (us % MICROS_PER_SECOND) * 1000L
- (day.toInt, secondsInDay * NANOS_PER_SECOND + nanos)
+ val julian_us = us + JULIAN_DAY_OF_EPOCH * MICROS_PER_DAY
--- End diff --
We haven't handle overflow in many places, the behavior is undefined, it
means will be garbage in the file, I think it's fine for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
