Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8535#discussion_r39108996
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -163,6 +164,63 @@ private[joins] object HashedRelation {
new GeneralHashedRelation(hashTable)
}
}
+
+ /**
+ * Consume a `LocalNode` to create a `HashedRelation`. Because
`LocalNode` is not an `Iterator`,
+ * we cannot use `apply` directly. Moreover, to avoid creating another
layer of `Iterator`, we
+ * have to duplicate most codes of `apply` here.
--- End diff --
I actually think implementing the wrapper is better since it's not very
complicated. Duplicate code in general is really bad. We can have something
like the following in `LocalNode`.
```
def asIterator: Iterator[InternalRow] = new LocalNodeIterator(this)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
