Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1068#discussion_r13931760
--- Diff: bin/spark-class ---
@@ -147,6 +147,13 @@ else
fi
if [[ "$1" =~ org.apache.spark.tools.* ]]; then
+ if test -z "$SPARK_TOOLS_JAR"; then
+ cat <<EOF 1>&2
--- End diff --
Could you just use two `echo` statements here? It's more consistent with
the rest of this script:
https://github.com/apache/spark/pull/1068/files#diff-fdf4d3e600042c63ffa17b692c4372a3L116
Also, it will save two lines and preserve the indentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
