Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8611#issuecomment-139137186
@yanboliang Thanks for the PR. I have done one pass. Please see my line
comments. On top of that, shall we consider the following:
* Parameterization
Different parameterizations of the Weibull distribution are used throughout
the code.
* epsilon, sigma in `AFTAggregator`
* lambda, k in `predict` of ` AFTRegressionModel`
* alpha, beta in the `generateAFTInput` of unit tests
I propose we standardize the parameterization so that the code base is
easier to understand and maintain. I prefer the parameterization in
`AFTAggregator`.
* Documentation of model and algorithm
I recommend we document the model as well as formula used in the estimation.
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
