GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/8699
[SPARK-10537][ML] document LIBSVM source options in public API doc and some
minor improvements
We should document options in public API doc. Otherwise, it is hard to find
out the options without looking at the code. I tried to make `DefaultSource`
private and put the documentation to package doc. However, since then there
exists no public class under `source.libsvm`, the Java package doc doesn't show
up in the generated html file. So I put the doc to `DefaultSource` instead.
There are several minor updates in this PR:
1. Do `vectorType == "sparse"` only once.
2. Update `hashCode` and `equals`.
3. Remove inherited doc.
4. Delete temp dir in `afterAll`.
@Lewuathe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mengxr/spark SPARK-10537
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8699
----
commit 70a87cfd35121c6bd4e09dfbeb7d745fb28b386c
Author: Xiangrui Meng <[email protected]>
Date: 2015-09-10T06:44:35Z
update LibSVMRelation; add package doc and minor fixes
commit fd7157f676332e011913c0b1b817cfc04d5c268a
Author: Xiangrui Meng <[email protected]>
Date: 2015-09-10T07:00:11Z
move test files
commit b7006cd6ae1e9e479123005c9925a0e3391ef5a6
Author: Xiangrui Meng <[email protected]>
Date: 2015-09-10T15:03:13Z
remove package doc and make DefaultSource public
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
