Github user concretevitamin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1118#discussion_r13937717
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/hiveOperators.scala 
---
    @@ -445,7 +445,19 @@ case class NativeCommand(
         if (sideEffectResult.size == 0) {
           context.emptyResult
         } else {
    -      val rows = sideEffectResult.map(r => new GenericRow(Array[Any](r)))
    +      // TODO: Need a better way to handle the result of a native command.
    +      // We may want to consider to use JsonMetaDataFormatter in Hive.
    --- End diff --
    
    Instead of introducing a special case here, can we put this piece of logic 
in a separate `DescribeCommand`? A while ago the introduction of `SetCommand` / 
`ExplainCommand` / `CacheCommand` serve partly to reduce special-casing in 
random places -- pinging @liancheng on this too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to