Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8604#discussion_r39253221
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/columnar/InMemoryColumnarTableScan.scala
 ---
    @@ -268,16 +268,21 @@ private[sql] case class InMemoryColumnarTableScan(
           readBatches.setValue(0)
         }
     
    -    relation.cachedColumnBuffers.mapPartitions { cachedBatchIterator =>
    -      val partitionFilter = newPredicate(
    -        partitionFilters.reduceOption(And).getOrElse(Literal(true)),
    -        relation.partitionStatistics.schema)
    +    val schema = relation.partitionStatistics.schema
    +    val schemaIndex = schema.zipWithIndex
    +    val relOutput = relation.output
    +    val buffers = relation.cachedColumnBuffers
    --- End diff --
    
    Could you please add a comment above this hunk to indicate that these 
variables are added to avoid unnecessary serialization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to