Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-139605519
> I think we need to have some more discussion about whether this change is
appropriate. I think the rationale for not including in sharedParams was to
hide the expertParams. It's also important to note that the semantics behind
decision tree's setCheckpointInterval differs from the current usage of
HasCheckpointInterval in ALS since it depends on cacheNodeIds.
@fliang I agree with this sentiment. Maybe the best place to put this
comment is in the cacheNodeIds param doc. @yanboliang would you mind sending a
little follow-up patch for this JIRA which adds a comment to the cacheNodeIds
doc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
