Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1019#discussion_r13955026
  
    --- Diff: conf/log4j.properties.template ---
    @@ -6,6 +6,6 @@ log4j.appender.console.layout=org.apache.log4j.PatternLayout
     log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p 
%c{1}: %m%n
     
     # Settings to quiet third party logs that are too verbose
    -log4j.logger.org.eclipse.jetty=WARN
    --- End diff --
    
    That other line has been in spark since way before we added this port 
retrying, so I don't think that's why it's there. IIRC there are various jetty 
services that will spit out logging information, especially at start up and 
shut down, and so we've always used this blanket statement. See for example 
Spark 0.5 which is more than 2 years old (before we even had a UI).
    
    
https://github.com/apache/spark/blob/branch-0.5/conf/log4j.properties.template#L7
    
    If you'd like to audit this at some point that would be great (it might be 
hard to find all cases where jetty will print something). But since this change 
is about the port issue specifically, it might be good not to change that other 
behavior in this patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to