Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8753#issuecomment-140183180
@jaceklaskowski A lot of your PRs do not have JIRAs. That's OK for
something very trivial but I'd have to push back on you now to follow
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
I think this doesn't add enough value to change. It puts the prop value
another hop away from its usage, and doesn't make a lot of sense to do this for
just one property. I agree it helps avoid typos, but also introduces
dependencies, and if taken to its logical conclusion, almost doesn't help avoid
mistakes -- you have to figure out what key is for which key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
