Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r39462606
--- Diff: sbin/start-history-server.sh ---
@@ -34,6 +34,7 @@ if [ $# != 0 ]; then
echo "Using command line arguments for setting the log directory is
deprecated. Please "
echo "set the spark.history.fs.logDirectory configuration option
instead."
export SPARK_HISTORY_OPTS="$SPARK_HISTORY_OPTS
-Dspark.history.fs.logDirectory=$1"
+ all_other_args="${@:2}"
--- End diff --
This seems sub optimal, the only way to specify a different properties file
involves specifying a different log directory, and in a deprecated fashion. I
think putting the argument parsing logic in HistoryServerArguments might be
better (option #3 from the JIRA) but thats just my opinion, maybe @andrewor14
might have a better idea as the original author of this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
