Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8711#discussion_r39471765
--- Diff: R/pkg/R/SQLContext.R ---
@@ -41,10 +41,7 @@ infer_type <- function(x) {
if (type == "map") {
stopifnot(length(x) > 0)
key <- ls(x)[[1]]
- list(type = "map",
- keyType = "string",
- valueType = infer_type(get(key, x)),
- valueContainsNull = TRUE)
+ paste0("map<string,", infer_type(get(key, x)), ">")
--- End diff --
One minor thing -- in the previous list we had an entry for
`valueContainsNull` that we dont have any more. I can see that this was always
`TRUE` so this probably doesn't affect functionality right now, but I am just
wondering if we had it for some other purpose
cc @daveis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
