Github user HyukjinKwon commented on the pull request:

    https://github.com/apache/spark/pull/8718#issuecomment-140693582
  
    It is OK for JDBC but for Parquet and ORC, it looks the conversion from 
`StringType` to `NumericType` are not safe.
    
    When the field type is `StringType`, then the given numeric value is 
converted to `String` and it compares both as string which ends up in wrong 
comparison. 
    
    Also, it looks sometimes `Cast()` fails when trying to cast unrealistic 
values. So, it returns false when it fails just in case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to