Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622243
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,12 +21,22 @@ package org.apache.spark.util
* An interface to represent clocks, so that they can be mocked out in
unit tests.
*/
private[spark] trait Clock {
+
+ /**
+ * @return the time in milliseconds
+ */
def getTimeMillis(): Long
+
+ /**
+ * @param targetTime block until the current time is at least this value
+ * @return current system time when wait has completed
--- End diff --
monotonic time removes guarantees that it reflects system time: move the
clock backwards and system time goes back, whereas monotonic time continues
forward. I *believe* that this also works the other way (I'm going to post a
couple of links on the JIRA, which may be enough to conclude "nanotime isn't
reliable on a manycore system and only leads to false expactions", hence change
this to a WONTFIX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
