Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39653380
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,12 +21,22 @@ package org.apache.spark.util
* An interface to represent clocks, so that they can be mocked out in
unit tests.
*/
private[spark] trait Clock {
+
+ /**
+ * @return the time in milliseconds
+ */
def getTimeMillis(): Long
+
+ /**
+ * @param targetTime block until the current time is at least this value
+ * @return current system time when wait has completed
--- End diff --
Not sure how that's related to my comment. I'm just saying that this method
doesn't wait until "system time", but whatever is the clock's definition of
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
