Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8737#discussion_r39666889
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -91,6 +91,7 @@ private[spark] abstract class YarnSchedulerBackend(
           filterParams.foreach { case (k, v) => 
conf.set(s"spark.$filterName.param.$k", v) }
           scheduler.sc.ui.foreach { ui => 
JettyUtils.addFilters(ui.getHandlers, conf) }
         }
    +    
scheduler.sc.executorAllocationManager.foreach(_.reSetNumExecutorsTarget())
    --- End diff --
    
    I think  it is not good to add this line of change here. I think your 
purpose is to detect whether the AM is reconnected, right? There's are many 
other ways for you to detect it, adding here is a little weird.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to