Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8512#issuecomment-140908654
@piaozhexiu I think that we still will have `mapred` API for a while. Do
you mean that we only maintain the `mapred` version of this PR? I think it
makes sense.
There are a few high level comments.
* I think it will be good to make sure it works with both Hadoop 1 and
Hadoop 2.
* Let's add more comments.
* Is there any part of the code that can be unit tested? I think it is fine
to leave some very AWS dependent part not tested for now since we will have a
feature flag.
btw, we may not be able to allocate time in the next one to two weeks to
finish our review. Once you have updated your PR, can you ping me and we will
allocate time to review it later. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
