Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8781#discussion_r39881201
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -588,12 +588,16 @@ class StreamingContext private[streaming] (
         state match {
           case INITIALIZED =>
             startSite.set(DStream.getCreationSite())
    -        sparkContext.setCallSite(startSite.get)
             StreamingContext.ACTIVATION_LOCK.synchronized {
               StreamingContext.assertNoOtherContextIsActive()
               try {
                 validate()
    -            scheduler.start()
    +            ThreadUtils.runInNewThread("streaming-start") {
    +              sparkContext.setCallSite(startSite.get)
    --- End diff --
    
    any reason why we need to move this in here? It's an atomic reference so it 
doesn't really matter which thread reads it right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to