Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-141532159
Looks like good improvements, less duplicated code, although there are
still some minor style issues. You might want to merge in the latest master
branch so that tests can be run.
Also as a note: to help relevant reviewers find your PR faster,
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-PullRequest
has some steps on how to name the PR (essentially
[SPARK-ISSUENUMBER][COMPONENT] - description) in this case maybe something like
starting the PR's title with [SPARK-10625][SQL] will help the PR be visible to
the people most able to help with the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
