Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8806#discussion_r39889195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -62,10 +62,23 @@ private[sql] object JacksonParser {
// guard the non string type
null
+ case (VALUE_STRING, BinaryType) =>
+ parser.getBinaryValue
+
case (VALUE_STRING, DateType) =>
-
DateTimeUtils.millisToDays(DateTimeUtils.stringToTime(parser.getText).getTime)
+ val stringValue = parser.getText
+ if (stringValue.contains("-")) {
+ // The format of this string will probably be "yyyy-mm-dd".
--- End diff --
Not sure whether this is still true if we take different locales into
consideration. Maybe use a `try` block here to parse the string as a date and
then fallback to int?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
