Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8799#discussion_r39893528
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFilters.scala ---
@@ -32,10 +32,10 @@ import org.apache.spark.sql.sources._
*/
private[orc] object OrcFilters extends Logging {
def createFilter(expr: Array[Filter]): Option[SearchArgument] = {
- expr.reduceOption(And).flatMap { conjunction =>
- val builder = SearchArgumentFactory.newBuilder()
- buildSearchArgument(conjunction, builder).map(_.build())
- }
+ for {
+ conjunction <- expr.reduceOption(And)
+ builder <- buildSearchArgument(conjunction,
SearchArgumentFactory.newBuilder())
+ } yield builder.build()
--- End diff --
It is not very clear how this part works. Can we add some comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
