Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/8842#issuecomment-141826632
  
    Running tests including things like RAT checks is usually for preparing a 
packaging of Spark. If you have `spark-defaults.conf` in there then you are 
also running a local Spark cluster or something, which is a different concern? 
I don't think these should happen from the same dir. 
    
    Conf files and templates are part of the copyrightable content of the 
project, so do technically need the same licensing regime, so I don't agree 
that `conf/` should be completely skipped. However `spark-defaults.conf` is not 
a product of the project. That seems to be the only file at issue. If it exists 
it was user created, and could be skipped. But then why is the change here 
skipping other stuff? it's not even skipping checks of `spark-defaults.conf`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to