Github user selvinsource commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-141826772
Exported models (regression and classification trees) look good now: the
validator generates the same results as spark.
Some minor comments:
- I would rename TreeModelUtils to something like PMMLTreeModelUtils...
- For the regression model we could add a target field for completeness
(see GeneralizedLinearPMMLModelExport)
- For the classification model, I can see you generate a class field with
values class_0 and class_1 but then the scored values are 0.0 and 1.0. We could
align them to be consistent (either the label or the double value).
@mengxr If you open a Jira ticket and assign it to me, I can update the
PMML documentation to include the new decision tree model.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
