Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6457#discussion_r40038202
  
    --- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala ---
    @@ -535,15 +538,82 @@ abstract class RpcEnvSuite extends SparkFunSuite with 
BeforeAndAfterAll {
           "local", env.address, "sendWithReply-unserializable-error")
         try {
           val f = rpcEndpointRef.ask[String]("hello")
    -      intercept[TimeoutException] {
    +      val e = intercept[Exception] {
             Await.result(f, 1 seconds)
           }
    +      assert(e.isInstanceOf[TimeoutException] || // For Akka
    +        e.isInstanceOf[NotSerializableException] // For Netty
    +      )
         } finally {
           anotherEnv.shutdown()
           anotherEnv.awaitTermination()
         }
       }
     
    +  test("port conflict") {
    +    val anotherEnv = createRpcEnv(new SparkConf(), "remote", 
env.address.port)
    +    assert(anotherEnv.address.port != env.address.port)
    +  }
    +
    +  test("send with authentication") {
    +    val conf = new SparkConf
    +    conf.set("spark.authenticate", "true")
    +    conf.set("spark.authenticate.secret", "good")
    +
    +    val localEnv = createRpcEnv(conf, "ssl-local", 13345)
    --- End diff --
    
    as before, using `ssl` in these tests is kinda confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to