Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8417#discussion_r40052425
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/util/RecurringTimer.scala
---
@@ -99,6 +99,8 @@ class RecurringTimer(clock: Clock, period: Long,
callback: (Long) => Unit, name:
nextTime += period
logDebug("Callback for " + name + " called at time " + prevTime)
}
+ clock.waitTillTime(nextTime)
--- End diff --
> Do we really need to wait till the next time? You could just take a
parameter specifying whether the method should be called on stop or not, and
then pass the current time in.
I just want to make it not break the semantics of RecurringTimer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
