Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8843#discussion_r40070190
  
    --- Diff: 
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
 ---
    @@ -114,10 +114,14 @@ public ExternalShuffleBlockResolver(TransportConf 
conf, File registeredExecutorF
                 "recover state for existing applications", 
registeredExecutorFile, e);
               if (registeredExecutorFile.isDirectory()) {
                 for (File f : registeredExecutorFile.listFiles()) {
    -              f.delete();
    +              if (!f.delete()) {
    +                logger.warn("error deleting " + f.getPath());
    --- End diff --
    
    You can use the `{}` placeholder syntax for slf4j loggers here, like in 
other Java files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to