Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8564#discussion_r40114403
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -298,11 +298,7 @@ class LinearRegressionModel private[ml] (
*/
// TODO: decide on a good name before exposing to public API
private[regression] def evaluate(dataset: DataFrame):
LinearRegressionSummary = {
- val t = udf { features: Vector => predict(features) }
- val predictionAndObservations = dataset
- .select(col($(labelCol)),
t(col($(featuresCol))).as($(predictionCol)))
-
- new LinearRegressionSummary(predictionAndObservations,
$(predictionCol), $(labelCol))
+ new LinearRegressionSummary(transform(dataset), $(predictionCol),
$(labelCol))
--- End diff --
No, it should permit columns to be turned off by setting them to empty
strings. That's useful for classification (with multiple output columns). It
may not be useful for regression currently, but will be when we add other
outputs (like variance estimates).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
