Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8836#discussion_r40125898
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
 ---
    @@ -60,12 +60,14 @@ class AFTSurvivalRegressionSuite extends SparkFunSuite 
with MLlibTestSparkContex
         assert(aftr.getMaxIter === 100)
         assert(aftr.getTol === 1E-6)
         val model = aftr.fit(datasetUnivariate)
    +      .setQuantileProbabilities(Array(0.1, 0.8))
    --- End diff --
    
    It is better to put setters before fit to make the estimator and the model 
it produces consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to