Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8865#discussion_r40144986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonGenerator.scala
---
@@ -118,7 +36,7 @@ private[sql] object JacksonGenerator {
* @param gen a JsonGenerator object
* @param row The row to convert
*/
- def apply(rowSchema: StructType, gen: JsonGenerator, row: InternalRow):
Unit = {
+ def apply(rowSchema: StructType, gen: JsonGenerator)(row: InternalRow):
Unit = {
--- End diff --
The removed `apply` method has the same signature. And personally I think
this one is semantically more preferable: `JacksonGenerator(schema, gen)`
returns a generator, then we apply this generator with a row to generate actual
JSON records.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
