GitHub user hsaputra opened a pull request:
https://github.com/apache/spark/pull/1157
Cleanup on Connection, ConnectionManagerId, ConnectionManager classes part 2
Cleanup on Connection, ConnectionManagerId, and ConnectionManager classes
part 2 while I was working at the code there to help IDE:
1. Remove unused imports
2. Remove parentheses in method calls that do not have side affect.
3. Add parentheses in method calls that do have side effect or not simple
get to object properties.
4. Change if-else check (via isInstanceOf) for Connection class type with
Scala expression for consistency and cleanliness.
5. Remove semicolon
6. Remove extra spaces.
7. Remove redundant return for consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/spark
cleanup_connection_classes_part2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1157
----
commit 85b24f70eae2a0ff06874a9b1f656a75550f04a9
Author: Henry Saputra <[email protected]>
Date: 2014-06-20T18:30:57Z
Cleanup on Connection and ConnectionManager classes part 2 while I was
working at the code there to help IDE:
1. Remove unused imports
2. Remove parentheses in method calls that do not have side affect.
3. Add parentheses in method calls that do have side effect.
4. Change if-else check (via isInstanceOf) for Connection class type with
Scala expression for consitency and cleanliness.
5. Remove semicolon
6. Remove extra spaces.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
