Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8874#discussion_r40232721
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -169,6 +168,9 @@ abstract class AggregateFunction2
override protected def genCode(ctx: CodeGenContext, ev:
GeneratedExpressionCode): String =
throw new UnsupportedOperationException(s"Cannot evaluate expression:
$this")
+
+ // Some aggregate function like Hive UDAF doesn't support partial
aggregation, should override it.
+ def supportPartial: Boolean = true
--- End diff --
How about we name it as `supportsPartial`? Also, for the doc, let's make it
as Scala doc, e.g.
```
/** Indicates if this function supports partial aggregation. */
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
