Github user ssimeonov commented on a diff in the pull request:
https://github.com/apache/spark/pull/8893#discussion_r40279751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -72,6 +72,18 @@ abstract class UnaryMathExpression(f: Double => Double,
name: String)
}
}
+// for floor and ceil which returns bigint instead of double
+abstract class UnaryMathExpressionWithBigIntRet(f: Double => Double, name:
String)
--- End diff --
Did you consider parameterizing `UnaryMathExpression` by the return type as
opposed to using inheritance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
