Github user rerngvit commented on a diff in the pull request:
https://github.com/apache/spark/pull/8882#discussion_r40295753
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -140,7 +140,11 @@ class CrossValidator(override val uid: String) extends
Estimator[CrossValidatorM
@Experimental
class CrossValidatorModel private[ml] (
override val uid: String,
+
+ /** The best model selected from cross validation */
--- End diff --
@jkbradley I don't fully understand. As far as I understand, @param is for
documenting arguments of methods. However, both bestModel and avgMetrics (that
Spark-9798 are about) are not arguments in any methods (including
constructors). Why should there be @params for the two members for the class?
Could you please help elaborate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
