Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/8112#discussion_r40339724
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -80,7 +96,18 @@ class CrossValidator(override val uid: String) extends
Estimator[CrossValidatorM
val epm = $(estimatorParamMaps)
val numModels = epm.length
val metrics = new Array[Double](epm.length)
- val splits = MLUtils.kFold(dataset.rdd, $(numFolds), 0)
+ val splits = if (schema.fieldNames.contains($(stratifiedCol))) {
--- End diff --
Agree. This could perform StratifiedSampling on a column "None" without the
user knowing. Added a check to see if user has explicitly set the column.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
