Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8907#discussion_r40373071
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/CatalystRowConverter.scala
---
@@ -302,7 +302,13 @@ private[parquet] class CatalystRowConverter(
}
override def addBinary(value: Binary): Unit = {
- updater.set(UTF8String.fromBytes(value.getBytes))
+ // The underlying `ByteBuffer` implementation is guaranteed to be
`HeapByteBuffer`, so here we
+ // are using `Binary.toByteBuffer.array()` to steal the underlying
byte array without copying
+ // it.
+ val buffer = value.toByteBuffer
--- End diff --
I didn't mean to try mine - I think the best way is to change Parquet to
give us exactly what we want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
